vweb: avoid the controllers needs to be defined in specific order#19182
Merged
medvednikov merged 1 commit intovlang:masterfrom Aug 19, 2023
Merged
vweb: avoid the controllers needs to be defined in specific order#19182medvednikov merged 1 commit intovlang:masterfrom
medvednikov merged 1 commit intovlang:masterfrom
Conversation
Casper64
approved these changes
Aug 19, 2023
Member
|
A great fix, thanks! |
Wertzui123
pushed a commit
to Wertzui123/v
that referenced
this pull request
Oct 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This P/R allows the use of the controllers in VWeb without need to worry about the order in which you put them in the list.
This should avoid user errors, and make it more easy to use VWeb controllers.
🤖 Generated by Copilot at 27c00f0
This pull request improves the vweb routing logic by fixing a bug and adding a new controller and test cases. It sorts the controllers by path length and checks for duplicate or conflicting paths. It also adds the
OtherHidedByOthercontroller and tests it with the/other/hideand/other/hide/pathroutes.🤖 Generated by Copilot at 27c00f0
OtherHidedByOtherto test the routing logic (link,link,link,link)